Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix manta testnet dns #1260

Merged
merged 3 commits into from
Nov 22, 2023
Merged

fix manta testnet dns #1260

merged 3 commits into from
Nov 22, 2023

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Nov 13, 2023

Description

Fix URL for nodes in manta-testnet chainspec


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Charles Ferrell <[email protected]>
@ferrell-code ferrell-code added C-cleanup Category: Issues documenting cleanup or PRs that clean code up A-development Area: Development Resources and Upgrades L-fixed Log: Issues and PRs related to bug fixes A-integration-test-checks A-unit-test-checks A-benchmark-checks labels Nov 13, 2023
Signed-off-by: Charles Ferrell <[email protected]>
@zqhxuyuan zqhxuyuan merged commit 686d6f8 into manta Nov 22, 2023
18 of 19 checks passed
@zqhxuyuan zqhxuyuan deleted the fer-genesis-manta-dns branch November 22, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-development Area: Development Resources and Upgrades A-integration-test-checks A-unit-test-checks C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants